-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Eskimi bidder documentation #4471
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gvl_id: 814 | ||
sidebarType: 1 | ||
schain_supported: true | ||
floors_supported: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pleased add additional meta information found here: https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter
media_types
: banner // this is not needed, but makes it clearersafeframes_ok
: true/false // makes the integration easier for publishersortb_blocking_supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add additional bidder parameters for ortb blocking? In the adapter code we're using prebid.js's ortb converter, but that won't populate bcat, badv and so on, right? So I guess for the initial version ortb_blocking_supported
will be set to false, but we're going to update it later as our backend supports it fully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrobakowski sounds like a good plan to me. Merging!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. (edit: I tried using github spaces to fix the PR and the buttons don't do what I thought they would)
* Add Eskimi bidder documentation * add safeframes_ok and ortb_blocking_supported fields to eskimi bidder docs
🏷 Type of documentation
📋 Checklist