Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs for Vidoomy blocking supported #4493

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

nimasrn
Copy link
Contributor

@nimasrn nimasrn commented Apr 18, 2023

🏷 Type of documentation

  • update bid adapter
  • new feature

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 4a96e1e
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/643eac2773028d0008354b28
😎 Deploy Preview https://deploy-preview-4493--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nimasrn nimasrn marked this pull request as ready for review April 19, 2023 13:26
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimasrn - please clarify this support. The requirement is that your adapter first prioritize ORTB-level parameters as you note in the example: $.bcat, $.battr, etc.

For Prebid Server, do you also accept these parameters as bidder-specific params? i.e. $.imp[].ext.prebid.bidder.vidoomy.{bcat, battr, etc}

That's what placing these values in the bidder params table implies. You should be aware that Prebid Server supports the ORTB Blocking module, so it's not clear why bidder-specific blocking params would be useful. But there's nothing wrong with supporting them as long as ORTB-supplied values are utilized.

@bretg bretg self-assigned this Apr 19, 2023
@bretg bretg added the question label Apr 19, 2023
@nimasrn
Copy link
Contributor Author

nimasrn commented Apr 21, 2023

@nimasrn - please clarify this support. The requirement is that your adapter first prioritize ORTB-level parameters as you note in the example: .bcat,.battr, etc.

For Prebid Server, do you also accept these parameters as bidder-specific params? i.e. $.imp[].ext.prebid.bidder.vidoomy.{bcat, battr, etc}

That's what placing these values in the bidder params table implies. You should be aware that Prebid Server supports the ORTB Blocking module, so it's not clear why bidder-specific blocking params would be useful. But there's nothing wrong with supporting them as long as ORTB-supplied values are utilized.

Yes, We support and first prioritize ORTB-level parameters for bcat, badv, bapp, btype and battr.

@muuki88 muuki88 merged commit 3ac6fc7 into prebid:master Apr 28, 2023
myDisconnect pushed a commit to eskimi/prebid.github.io that referenced this pull request May 23, 2023
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants