AN bidder docs: note required pub-placement match #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjacobsonny would appreciate any feedback on this text, particularly any technical nuances that need to be conveyed, or if this is over-/understating things. |
mjacobsonny
reviewed
Nov 22, 2017
dev-docs/bidders/appnexus-ast.md
Outdated
| @@ -19,6 +19,10 @@ adapter include: | |||
| - Will continue to be upgraded as enhancements are made to Prebid.js | |||
| for expanding capabilities | |||
|
|
|||
| {: .alert.alert-danger :} | |||
| **All AppNexus placements on the page must come from the same publisher** | |||
There was a problem hiding this comment.
"All AppNexus placements included in a single call to requestBids must belong to the same Publisher object"
dev-docs/bidders/appnexus-ast.md
Outdated
| @@ -19,6 +19,10 @@ adapter include: | |||
| - Will continue to be upgraded as enhancements are made to Prebid.js | |||
| for expanding capabilities | |||
|
|
|||
| {: .alert.alert-danger :} | |||
| **All AppNexus placements on the page must come from the same publisher** | |||
| All AppNexus placement IDs across all ad units included in the page-level auction **MUST** belong to the same publisher object in the AppNexus system. If there are placements in the bid request from two or more different publishers, the ad call will fail. This may cause the page to break entirely, depending on how the publisher has implemented Prebid.js. | |||
There was a problem hiding this comment.
Would stress that the restriction:
- Applies to the AppNexus placements included in a single call to
requestBids - Does not extend to adapters that are aliasing the AppNexus adapter
- Really should not cause "the page to break entirely". Worst case scenario is that the AppNexus bidder will not return demand.
|
Thanks @mjacobsonny - updated based on your feedback, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.