-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete removed aliases docs #4839
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for wanting to keep stuff clean @GeneGenie , but we don't normally doc files. Publishers often use very old versions of PBJS where these bidders are still available.
Generally what we do is add a flag enable_download: false
to the header so it disappears off the download page, and if possible a pbjs_version_notes:
field saying something like "removed in 6.0"
We have an open item to support an "archive" page to get them off the main PBJS bidders page.
However, you're a Prebid veteran, so we might be able to take your word for it if you are absolutely sure that there's no publisher on the planet still using these bidders.
@GeneGenie any update on this? |
@muuki88 updated, sorry for delays. |
No worries |
🏷 Type of documentation
📋 Checklist
Adtelligent Bid Adapter : remove unuused aliases Prebid.js#10431