Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anyclip bidder dev doc #5199

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Anyclip bidder dev doc #5199

merged 5 commits into from
Apr 24, 2024

Conversation

basil79
Copy link
Contributor

@basil79 basil79 commented Mar 13, 2024 •
edited
Loading

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 8de29bb
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6602a1664ab9e500082b7a85
😎 Deploy Preview https://deploy-preview-5199--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bretg
bretg requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil79 - you're missing quite a few of the metadata fields requested in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

And gpp_supported has been deprecated, replaced with gpp_sid

Some fields missing: fpd_supported, multiformat_supported, ortb_blocking_supported, privacy_sandbox

changed gpp_support to gpp_sids: usp, added dchain_supported: false, …
8de29bb 
…fpd_supported: false, multiformat_supported: will-not-bid, ortb_blocking_supported: true, privacy_sandbox: no
@basil79
Copy link
Contributor Author

basil79 commented Mar 26, 2024 •
edited
Loading

@basil79 - you're missing quite a few of the metadata fields requested in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

And gpp_supported has been deprecated, replaced with gpp_sid

Some fields missing: fpd_supported, multiformat_supported, ortb_blocking_supported, privacy_sandbox

@bretg , changes implemented, please re-check, thanks !

bretg
bretg approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick update

@bretg
Copy link
Contributor

bretg commented Apr 24, 2024

part of 8.43

@bretg bretg merged commit 3cc89c7 into prebid:master Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil79 @bretg