EXADS Bid Adapter: initial release #5237
Conversation
feat: added exadsadserver.md for PR purposes
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dev-docs/bidders/exadsadserver.md
Outdated
| #### General settings | ||
|
|
||
| Use `setConfig` to instruct Prebid.js to initilize the exadsBidAdapter, as specified below. | ||
|
|
||
| * Set "debug" as true if you need to read logs; | ||
| * Set "gdprApplies" as true if you need to pass gdpr consent string; | ||
| * The tcString is the iabtcf consent string for gdpr; | ||
| * Uncomment the cache instruction if you need to configure a cache server (e.g. for instream video) | ||
|
|
||
| ```js | ||
| pbjs.setConfig({ | ||
| debug: false, | ||
| //cache: { url: "https://prebid.adnxs.com/pbc/v1/cache" }, | ||
| consentManagement: { | ||
| gdpr: { | ||
| cmpApi: 'static', | ||
| timeout: 1000000, | ||
| defaultGdprScope: true, | ||
| consentData: { | ||
| getTCData: { | ||
| tcString: consentString, | ||
| gdprApplies: false, // set to true to pass the gdpr consent string | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
| ``` |
There was a problem hiding this comment.
This is prebid core related stuff and shouldn't be part of the adapter. The danger that this gets stale is pretty high
There was a problem hiding this comment.
Removed all General settings section
dev-docs/bidders/exadsadserver.md
Outdated
| ```js | ||
| pbjs.setConfig({ | ||
| video: { | ||
| providers: [ | ||
| { | ||
| divId: 'player', // the id related to the videojs tag in your body | ||
| vendorCode: 2, // videojs, | ||
| playerConfig: { | ||
| params: { | ||
| adPluginConfig: { | ||
| numRedirects: 10, | ||
| }, | ||
| vendorConfig: { | ||
| controls: true, | ||
| autoplay: true, | ||
| preload: 'auto', | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }); | ||
| ``` |
There was a problem hiding this comment.
Is this specific to your adapter? Otherwise if this is already present in the prebid docs, I would remove it as well
There was a problem hiding this comment.
Removed this example code. It is not specific to our adapter.
dev-docs/bidders/exadsadserver.md
Outdated
|
|
||
| If you will work with video stream ad formats you could choose to use the prebidJS video module to render the video using already supported video players as videoJS. | ||
| Add the `video` config if you need to render videos using the video module. | ||
| For more info navigate to <https://docs.prebid.org/prebid-video/video-module.html>. |
There was a problem hiding this comment.
Please use relative links to make them correct in every environment.
There was a problem hiding this comment.
Sorry @muuki88, what do you mean? The unique url that I'm using here is related to the prebid doc. Are there different environments for it? Probably I missed something.
There was a problem hiding this comment.
Hi
Use links like this /dev-docs/... , not a full URL
dev-docs/bidders/exadsadserver.md
Outdated
| * **w** - width of the image in pixels, optional (integer) | ||
| * **h** - height of the image in pixels, optional (integer) | ||
|
|
||
| ##### DSA |
There was a problem hiding this comment.
I appreciate you documenting that you support DSA. IMHO a link to https://github.com/InteractiveAdvertisingBureau/openrtb/blob/main/extensions/community_extensions/dsa_transparency.md should be enough and dsa_supported: true in the meta data
There was a problem hiding this comment.
Removed all dsa documentation sections.
dev-docs/bidders/exadsadserver.md
Outdated
| gvl_id: 1084 | ||
| tcfeu_supported: true | ||
| media_types: banner, video, native | ||
| gpp_sids: tcfeu |
There was a problem hiding this comment.
I couldn't find any trace of gpp in your adapter code. Only gdpr is handled here
https://github.com/prebid/Prebid.js/pull/11284/files#diff-7b07170acdd41519116c203893aece137dd33e19f8475b5c7d806479b139de6fR68-R72
There was a problem hiding this comment.
I confirm that for now we'll support only gdpr. Removed gpp_sids param.
* fix: related to markdown lint validation * fix: from code review * fix: from code review
* fix: related to markdown lint validation * fix: from code review * fix: from code review * fix: from CR
|
Hi @muuki88, do you have some updates about the review? In the mean time the code PR was merged into master. |
🏷 Type of documentation
📋 Checklist