Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/colombia bid adapter #5312

Merged
merged 7 commits into from
May 31, 2024

Conversation

adtech-colombia
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented May 13, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 43de52e
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6659a625538dcd00082a6e57
😎 Deploy Preview https://deploy-preview-5312--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ChrisHuie ChrisHuie added the LGTM label May 16, 2024
@ChrisHuie ChrisHuie self-requested a review May 16, 2024 18:13
@ChrisHuie ChrisHuie added on hold and removed LGTM labels May 16, 2024
@ChrisHuie ChrisHuie self-requested a review May 16, 2024 18:14
@adtech-colombia
Copy link
Contributor Author

adtech-colombia commented May 30, 2024

We have done suggested changes. Please review and merge.

Code branch already merged: prebid/Prebid.js#11478

dev-docs/bidders/colombia.md Outdated Show resolved Hide resolved
dev-docs/bidders/colombia.md Outdated Show resolved Hide resolved
@bretg bretg added needs work and removed on hold labels May 30, 2024
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates @adtech-colombia - but you're still missing a lot of the metadata Prebid publishers have asked for. See https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter ... the full list would look something like:

tcfeu_supported: true/false
dsa_supported: true/false
gvl_id: none
usp_supported: true/false
coppa_supported: true/false
gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp
schain_supported: true/false
dchain_supported: true/false
userId: (list of supported vendors)
media_types: banner, video, native
safeframes_ok: true/false
deals_supported: true/false
floors_supported: true/false
fpd_supported: true/false
pbjs: true/false
pbs: true/false
prebid_member: true/false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid
ortb_blocking_supported: true/partial/false
privacy_sandbox: no or comma separated list of paapi, topics

Explicit 'false' is better than omission.

Since your adapter was released yesterday, will go ahead and merge this, but please take an item to revisit this metadata in the next week or so please.

@bretg bretg merged commit 1a17d93 into prebid:master May 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants