Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added publisherId param to bid params in insticator adapter doc #5406

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Added publisherId param to bid params in insticator adapter doc #5406

merged 3 commits into from
Jun 16, 2024

Conversation

shashidhar-insticator
Copy link
Contributor

@shashidhar-insticator shashidhar-insticator commented Jun 7, 2024 •
edited
Loading

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Here is the prebid.js code PR:
prebid/Prebid.js#11733

@netlify Netlify
Copy link

netlify bot commented Jun 7, 2024 •
edited
Loading

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 70b3caa
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/666b1b1f1ef92d0008f85f8b
😎 Deploy Preview https://deploy-preview-5406--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

muuki88
muuki88 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shashidhar-insticator please always link the pull request in the description of the PR or the otherway round. It helps us to review your changes faster as we merge only if the associated code PR is merged.

@shashidhar-insticator
Copy link
Contributor Author

prebid/Prebid.js#11733 (comment)

@shashidhar-insticator please always link the pull request in the description of the PR or the otherway round. It helps us to review your changes faster as we merge only if the associated code PR is merged.

@muuki88 Thank you for reviewing, I have added the code PR for the reference as you suggested.

@shashidhar-insticator
Copy link
Contributor Author

@muuki88
We changed userIds to all from none which we already support in the code, just updating the docs as per our code

@muuki88 muuki88 merged commit b6e6623 into prebid:master Jun 16, 2024
5 checks passed
BIGOAds pushed a commit to BIGOAds/prebid.github.io that referenced this pull request Jul 5, 2024
@shashidhar-insticator
Added publisherId param to bid params in insticator adapter doc (preb…
15f8f07 
…id#5406)

* Added publisherId param to bid params in insticator adapter doc

* chaning userIds from none to all

---------

Co-authored-by: shashidharm <shashidhar397@gmai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
LGTM Pending PBJS Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shashidhar-insticator @muuki88