Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent User ID Module: Eliminating live-connect NPM Dependency #5567

Merged
merged 12 commits into from
Oct 11, 2024

Conversation

3link
Copy link
Contributor

@3link 3link commented Aug 23, 2024

Allows to use the LiveIntent user ID module with an instance of LiveConnect v3 present on the page instead of inlining the LiveConnect NPM module into the user ID module as described here: prebid/Prebid.js#11541.

The goal is to support both standard/minimal mode as well as the external mode during the migration phase. Once all our customers have migrated away from using standard/minimal mode, we will deprecate this mode and delete the LiveConnect NPM module dependency from Prebid together with all the code that depends on it.

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

peixunzhang and others added 9 commits August 12, 2024 16:00
Implement LiveIntent Prebid User Id Module Based On The Hub
Co-authored-by: Viktor Dreiling <34981284+3link@users.noreply.github.com>
Co-authored-by: Viktor Dreiling <34981284+3link@users.noreply.github.com>
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 797f088
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66f1906c0243e100080daa9c
😎 Deploy Preview https://deploy-preview-5567--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3link 3link marked this pull request as ready for review August 26, 2024 09:15
@bretg
Copy link
Contributor

bretg commented Sep 12, 2024

@dgirardi - this looks ok to me. Can you please confirm the gulp build command they're suggesting here is going to work?

@bretg bretg added the question label Sep 12, 2024
@bretg bretg self-assigned this Sep 12, 2024
@bretg
Copy link
Contributor

bretg commented Sep 13, 2024

@deepthivenkat - please fix the linting error -- multiple blank lines

@bretg bretg added LGTM and removed question labels Oct 11, 2024
@bretg bretg merged commit 0b5c300 into prebid:master Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants