Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adhese] Document pbs ext parameters #5618

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[Adhese] Document pbs ext parameters #5618

merged 3 commits into from
Oct 11, 2024

Conversation

mefjush
Copy link
Contributor

@mefjush mefjush commented Sep 24, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 07253d6
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67096785210472000893c893
😎 Deploy Preview https://deploy-preview-5618--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Updated to align with the way that others have dealt with differences between their client-side and server-side adapters -- have different rows with comments.
@bretg
Copy link
Contributor

bretg commented Oct 11, 2024

@mefjush - I'll go ahead and merge this, but I'm asking Adhese to make these two changes:

  1. First, update your server-side adapter to support both data and targets. It's a significant annoyance to publishers when the client-side and server-side adapters don't agree on parameter names because then they can't use the s2s testing module. It should be easy for your server-side adapter to listen for data and just treat is as targets.
  2. You're missing a lot of metadata in this docs file. Please look at https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter and supply all the missing metadata. e.g.
dsa_supported: true/false
usp_supported: true/false
coppa_supported: true/false
gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp
schain_supported: true/false
dchain_supported: true/false
userId: (list of supported vendors)
media_types: banner, video, native
safeframes_ok: true/false
deals_supported: true/false
floors_supported: true/false
fpd_supported: true/false
prebid_member: true/false
multiformat_supported: will-bid-on-any, will-bid-on-one, will-not-bid
ortb_blocking_supported: true/partial/false
privacy_sandbox: no or comma separated list of `paapi`, `topics`

@bretg bretg merged commit e51f5b5 into prebid:master Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants