Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated key 'pos' in adUnit.mediaTypes.video #5622

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

sebhtml
Copy link
Contributor

@sebhtml sebhtml commented Sep 25, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 0639bb7
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66f5588bf87ae300079d9bc2
😎 Deploy Preview https://deploy-preview-5622--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@lpagnypubstack lpagnypubstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
It seems that the rendering is not correct : https://deploy-preview-5622--prebid-docs-preview.netlify.app/dev-docs/adunit-reference

A new row is added for "OpenRTB page position value: 0=unknown, 1=above-the-fold, 3=below-the-fold, 4=header, 5=footer, 6=sidebar, 7=full-screen" instead of being added into the "pos" row.
Capture d’écran 2024-09-26 à 08 35 04
Can you please fix it?

@sebhtml
Copy link
Contributor Author

sebhtml commented Sep 26, 2024

@lpagnypubstack lpagnypubstack merged commit f2ef30a into prebid:master Sep 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants