Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bidder:ehealthcaresolutions #5686

Merged
merged 6 commits into from
Nov 22, 2024
Merged

New Bidder:ehealthcaresolutions #5686

merged 6 commits into from
Nov 22, 2024

Conversation

pranavsheth
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 4c59b5f
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67343cb1003f46000876d6f4
😎 Deploy Preview https://deploy-preview-5686--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that the inclusion of tapnative here is accidental. Please remove.

And ehealthcaresolutions is in the wrong directory -- please move to /dev-docs/bidders

@pranavsheth
Copy link
Contributor Author

I suspect that the inclusion of tapnative here is accidental. Please remove.

And ehealthcaresolutions is in the wrong directory -- please move to /dev-docs/bidders

@bretg we have move ehealthcaresolutions to dev-docs/bidders.

we are using same fork which we used for tapnative. so how you are suggesting to remove tapnative from here?

@bretg
Copy link
Contributor

bretg commented Nov 12, 2024

we are using same fork which we used for tapnative. so how you are suggesting to remove tapnative from here?

This is a git thing. You'll have to research it -- basically, just commit only the files you've changed into the fork.

@pranavsheth
Copy link
Contributor Author

we are using same fork which we used for tapnative. so how you are suggesting to remove tapnative from here?

This is a git thing. You'll have to research it -- basically, just commit only the files you've changed into the fork.

HI @bretg ,
updated from master, can you please check and merged to master.
thanks.

@ChrisHuie ChrisHuie merged commit 7e79420 into prebid:master Nov 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants