add notes on handling pbs only bidders #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
CC @dbemiller |
bretg
requested changes
Jun 13, 2018
| @@ -43,6 +43,8 @@ Prebid Server is an open source project. [The source code is hosted under the P | |||
| ## Step 2. Download Prebid.js with Prebid Server enabled | |||
|
|
|||
| - Go to [the Prebid.org download page]({{site.baseurl}}/download.html), select all the demand adapters you want to work with, and include "Prebid Server". | |||
| - Some Prebid Server demand adapters may not have a corresponding client-side adapter that's present on the download page. In this case, just ensure to select "Prebid Server" as part of your build and you will be able to interact with these Prebid Server only bidders. | |||
| - In lieu of the point above, we still strongly recommend to select any listed demand adapters in your build. These additional selections will allow any client-side features (such as userSyncs) to function as well as allow you to easily use any of the adapter's currently registered aliases. | |||
There was a problem hiding this comment.
'In lieu of' means 'Instead of' -- I think you mean "despite the point above", but I recommend dropping the whole clause.
| @@ -124,6 +126,10 @@ pbjs.que.push(function() { | |||
| **OpenRTB Endpoint** | |||
| If your `s2sConfig.endpoint` points to a url containing the path `/openrtb2/`, such as the AppNexus-hosted endpoint https://prebid.adnxs.com/pbs/v1/openrtb2/auction', Prebid will communicate with that endpoint using the OpenRTB protocol. | |||
|
|
|||
| {: .alert.alert-info :} | |||
| **Aliasing Prebid Server only bidders** | |||
| If you wish to set/use an alias for a Prebid Server only bidders, simply list the alias in your `s2sConfig.bidders` field and call the [`pbjs.aliasBidder` method](http://prebid.org/dev-docs/publisher-api-reference.html#module_pbjs.aliasBidder) in your prebid code (prior to the `pbjs.requestBids`) to register the alias. | |||
There was a problem hiding this comment.
Plurality doesn't match here... change bidders to bidder?
|
Thanks for the feedback @bretg, I have made the changes you recommended. |
bretg
approved these changes
Jun 14, 2018
|
thanks @jsnellbaker |
|
released with 1.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation updates related to prebid/Prebid.js#2704
Add notes about how to handle PBS only bidders for anyone using PBS.