Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename bidAdapter and add to partners #962

Merged
merged 5 commits into from
Oct 5, 2018
Merged

Rename bidAdapter and add to partners #962

merged 5 commits into from
Oct 5, 2018

Conversation

prebidRxRTB
Copy link
Contributor

No description provided.

@jsnellbaker
Copy link
Contributor

Related to prebid/Prebid.js#3070

bretg
bretg requested changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please flip the Type and Example columns in your table. We're trying to keep them consistent across bidders.

@prebidRxRTB
Copy link
Contributor Author

Update

bretg
bretg approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks

@bretg bretg added LGTM and removed needs work labels Sep 17, 2018
@prebidRxRTB prebidRxRTB mentioned this pull request Sep 29, 2018
Merged
1 task
@bretg
Copy link
Contributor

bretg commented Oct 1, 2018

Will be released with 1.26

@bretg bretg merged commit 7d65edd into prebid:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
LGTM Pending PBJS Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prebidRxRTB @jsnellbaker @bretg