RAD-2446: add referrer detection info for new refererInfo property #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Sep 24, 2018
dev-docs/bidder-adaptor.md
Outdated
|
|
||
| Your integration of referrer information would look something like this: | ||
|
|
||
| {% highlight js %} |
There was a problem hiding this comment.
I think we can remove this js code block because it is for appnexus adapter and each adapter will have their own implementation.
dev-docs/bidder-adaptor.md
Outdated
| - `numIframes`: the number of iFrames. | ||
| - `stack`: a string of comma-separated URLs of all origins. | ||
|
|
||
| Your integration of referrer information would look something like this: |
There was a problem hiding this comment.
We can add something here like:
refererInfo returns raw url. You may want to encode urls before adding it to request payload.
There was a problem hiding this comment.
great callout, I added this in.
jaiminpanchal27
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaiminpanchal27 Please take a look and let me know if I got this right or I missed anything. Thanks!