Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed placement id to be string instead of int #988

Merged
merged 2 commits into from
Oct 10, 2018
Merged

changed placement id to be string instead of int #988

merged 2 commits into from
Oct 10, 2018

Conversation

omerko
Copy link
Contributor

@omerko omerko commented Oct 5, 2018

No description provided.

bretg
bretg requested changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a PR associated with this doc change?

Please update the example to have quotes around the string.

bretg
bretg approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bretg bretg merged commit 69ff8ae into prebid:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerko @bretg