Replace special characters in pkg name when checking npm_config env (#…

…109) Modify to substitute '_' for all special characters as well as '-'. Follow-up to #97.
prebuild · Sep 12, 2019 · 3c3cfee · 3c3cfee
1 parent 652f169
commit 3c3cfee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/test/util-test.js b/test/util-test.js
@@ -80,7 +80,7 @@ test('urlTemplate() returns different templates based on pkg and rc', function (
     download: true
   }
   delete o7.binary
-  var envProperty = 'npm_config_' + o7.pkg.name.replace(/-/g, '_') + '_binary_host'
+  var envProperty = 'npm_config_' + o7.pkg.name.replace(/[^a-zA-Z0-9]/g, '_') + '_binary_host'
   process.env[envProperty] = 'http://overriden-url.com/overriden-path'
   var t7 = util.urlTemplate(o7)
   delete process.env[envProperty]

diff --git a/util.js b/util.js
@@ -61,7 +61,7 @@ function urlTemplate (opts) {
 }
 
 function getHostMirrorUrl (opts) {
-  var propName = 'npm_config_' + (opts.pkg.name || '').replace(/-/g, '_') + '_binary_host'
+  var propName = 'npm_config_' + (opts.pkg.name || '').replace(/[^a-zA-Z0-9]/g, '_') + '_binary_host'
   return process.env[propName] || process.env[propName + '_mirror']
 }