Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to use docker-images #6

Closed
vweevers opened this issue Apr 27, 2019 · 1 comment · Fixed by #7
Closed

Rewrite to use docker-images #6

vweevers opened this issue Apr 27, 2019 · 1 comment · Fixed by #7

Comments

@vweevers
Copy link
Member

vweevers commented Apr 27, 2019

Should we deprecate this in favor of https://github.com/prebuild/docker-images?

@vweevers vweevers added the question Support or open question(s) label Apr 27, 2019
@vweevers
Copy link
Member Author

vweevers commented Nov 3, 2019

On second thought, we can repurpose this.

With the exception of Windows & Mac, leveldown's prebuilds are built in docker:

https://github.com/Level/leveldown/blob/f637eb79d52b211494e61e47610a5c6112f4f25a/package.json#L20-L26

Currently spread out over 3 travis jobs. We could make that one job, that calls prebuildify-cross, which will do all of the above (i.e. building for all platforms by default). Then prebuildify-cross can be reused by other projects. Ideally that'd be as simple as adding one dependency, so we may want to copy some behaviors from prebuild-ci (checking whether it needs to run and doing uploads, which in the prebuildify* setup is handled by travis).

@vweevers vweevers changed the title Deprecate this? Rewrite to use docker-images Nov 3, 2019
@vweevers vweevers removed the question Support or open question(s) label Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant