Rewrite as node cli using prebuild/docker-images #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added a commit
to Level/rocksdb
that referenced
this pull request
Nov 9, 2019
Using the new prebuildify-cross (prebuild/prebuildify-cross#7). This makes the prebuilt binary for linux compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc. Following Level/leveldown#674.
vweevers
commented
Nov 10, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ahdinosaur Could you |
vweevers
added a commit
to Level/rocksdb
that referenced
this pull request
Nov 16, 2019
This makes the prebuilt binary for linux compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc. Following Level/leveldown#674. This rocksdb PR additionally uses the new prebuildify-cross (prebuild/prebuildify-cross#7). That's a github dependency for now; waiting for npm ownership.
vweevers
added a commit
to Level/leveldown
that referenced
this pull request
Nov 17, 2019
Which has been rewritten, see prebuild/prebuildify-cross#7. It's a github dependency for now; waiting for npm ownership.
vweevers
added a commit
to Level/rocksdb
that referenced
this pull request
Nov 17, 2019
This makes the prebuilt binary for linux compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc. Following Level/leveldown#674. This rocksdb PR additionally uses the new prebuildify-cross (prebuild/prebuildify-cross#7). That's a github dependency for now; waiting for npm ownership.
vweevers
added a commit
to Level/leveldown
that referenced
this pull request
Nov 17, 2019
Which has been rewritten, see prebuild/prebuildify-cross#7. It's a github dependency for now; waiting for npm ownership.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fyi @ahdinosaur
Closes #6, closes #5.