Moving solverdummy into examples folder #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
approved these changes
May 1, 2022
There was a problem hiding this comment.
Overall good step into the right direction. From my perspective you can merge this. I just have a few remarks that you can consider, if you want. But the current solution is also fine:
- My muscle memory typed
python3 solverdummy.py ../precice-config.xml SolverTwo MeshTwo. This, of course, does not work, because the structure isexamples/solverdummy/solvedummy.pyandprecice-config.xmllies next tosolverdummy.py, notexamples/solverdummies/python/solverdummy.pyandprecice-config.xmllies one level above. This would be the 100% consistent version, but also overengineered. - What about the changes introduced in Remove meshName from solverdummies input arguments precice#1256 for the other solverdummies? Could also be done in another PR, but please don't forget it.
|
I will remove the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the solverdummy to a newly created
examplesfolder to make it consistent with the precice repository.