-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradient related API #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, the documentation needs some clarification. Please apply relevant comments to all API functions (didn't look at all). The docker image has been updated. As far as I understand you can add tests now and they should work.
Co-authored-by: David Schneider <david.schneider@ipvs.uni-stuttgart.de>
@IshaanDesai @BenjaminRodenberg @davidscn Tests are ready. Since gradient data has no read API, tests are only write-type tests that checks different data structures. |
How can we validate the correctness of the data passed to preCICE? Can we execute a basic integration test or access preCICE internals? |
I have not looked at the tests yet but in general the idea of mock testing in the python bindings is that we provide an expected output to a mocked preCICE interface and then we pass the data and compare it against the expected (correct) data already present inside the mocked preCICE interface. |
So can I write the assertion in |
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API and tests look good now 👍 I will try to update the Spack image so that the build goes through and then we can merge this
@IshaanDesai is this now ready to merge? |
@davidscn @kursatyurt just sync with develop and then we can proceed with merging |
Done!. |
This PR adds nearest neighbour gradient related API to python bindings