Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility v3.0.0 #147

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

BenjaminRodenberg
Copy link
Member

Ensures compatibility to preCICE v3.0.0.

This PR should work with https://github.com/precice/precice/tree/develop-v3.0.0.

@IshaanDesai
Copy link
Member

Can we sync this with the latest develop to ensure that when we plan to merge this we would not have excessive conflicts?

@BenjaminRodenberg
Copy link
Member Author

Can we sync this with the latest develop to ensure that when we plan to merge this we would not have excessive conflicts?

Done.

@IshaanDesai
Copy link
Member

Since precice/precice#1366 has now been merged upstream, we can also start moving the bindings to v3.0.0. @BenjaminRodenberg should we start by merging this PR? I am open to suggestions if you already have some order of doing things in mind.

@BenjaminRodenberg
Copy link
Member Author

As far as my plans are concerned this PR should be ready to merge. I think another round of manual testing does not harm. @IshaanDesai Feel free to play around with the current develop state of preCICE and this PR. I think this is a good step to understand the upcoming changes in preCICE as well.

If after testing everything looks good, you can just merge. If you find something that is not documented or broken, this is a good thing to fix before merging.

@BenjaminRodenberg BenjaminRodenberg marked this pull request as ready for review November 23, 2022 12:36
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some manual testing and everything seems to be in order for now. If something does break, we can fix it post merge.

@IshaanDesai IshaanDesai merged commit a142d01 into precice:develop Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change will break backwards compatibilty compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants