Make bindings compatible with precice:develop #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IshaanDesai can you review this PR? I think we can ignore spack. All other tests are working now. Feel free to directly squash & merge, if you think that everything is ok. |
IshaanDesai
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the develop branch of the bindings compatible with precice:develop.
Closes #161, closes #155
This PR contains all the changes from #159, but uses a simpler testing procedure.
important The docker image
benjaminrodenberg/precice:developis not maintained. Meaning: We will have to update it manually. This is currently a workaround, because I think cannot wait until precice/precice#1115 or precice/precice#1544 is resolved.