Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cython as dependency required during installation #177

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Add Cython as dependency required during installation #177

merged 2 commits into from
Feb 5, 2024

Conversation

IshaanDesai
Copy link
Member

Possibly resolves #176

@IshaanDesai IshaanDesai self-assigned this May 10, 2023
BenjaminRodenberg
BenjaminRodenberg approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see a (documented) reason speaking against adding it and if it is causing trouble without, we obviously need it.

@IshaanDesai IshaanDesai removed the request for review from fsimonis February 5, 2024 11:16
@IshaanDesai IshaanDesai merged commit c4d9786 into develop Feb 5, 2024
18 checks passed
@IshaanDesai IshaanDesai deleted the cython-dependency branch February 5, 2024 11:17
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Jun 10, 2024
Open
BenjaminRodenberg pushed a commit that referenced this pull request Aug 27, 2024
@IshaanDesai @BenjaminRodenberg
Add Cython as dependency required during installation (#177)
8a02cea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminRodenberg BenjaminRodenberg BenjaminRodenberg approved these changes

Assignees

@IshaanDesai IshaanDesai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install --user pyprecice - fails Cython dependency
2 participants
@IshaanDesai @BenjaminRodenberg