Compatibility with precice:develop #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
There are a lot of changes in this PR and this makes the diff hard to read. One reason is clearly the renaming of some important files and classes and I think we cannot really improve readability here. Still, it would be nice to extract some minor parts into independent commits for a nicer git history.
Besides readability: From the feature-side everything looks ok (tests work on my system)
Comment on lines
+819
to
+820
| cdef vector[int] cpp_ids = vertex_ids | ||
| cdef vector[double] cpp_values = values.flatten() |
There was a problem hiding this comment.
Would be good, if we could avoid this explicit copying of data and use ranges instead. But let's do this as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the develop branch of the bindings compatible with the latest state of precice:develop.