-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable build-docker workflow on push to master #196
Conversation
This of course only "fixes" the GitHub view. I can also fully revert all other changes to the Dockerfile etc and revert to the previous state (which would still break if anyone tried to build for master, as before we ever touched this workflow, but one would never see that). |
Note also that, as I am not a maintainer of this repository, I have no idea what side-implications pushing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not foresee any issue right now. Pushing a hotfix directly to master should not be a problem.
I think the main question here is what we actually want. I already discussed this to some degree with @fsimonis.
My personal opinion: I can currently live without having an official docker release of the python bindings and the fenics adapter. Having the develop images is fine. With the releases on PyPI and conda I think our users also have good means to get the packages. |
✅ |
Remove some unnecessary code.
@MakisH I removed some code that should now have become unnecessary. Can you do a final check and then merge? |
See precice/python-bindings#196. We decided to not release a docker container for the python bindings and the fenics adapter, because this is unnecessary.
Looks good to me. You merge. :-) |
This disables building the Docker image on push to master, which was first enabled in #186. This workflow was simply not triggered before, but currently fails #191.
Publishing such a Docker image is not needed for the system tests anymore.
@BenjaminRodenberg @IshaanDesai I am directly contributing to the master branch as a hotfix, since this only fixes (disables) the broken GitHub Actions workflow.