Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable build-docker workflow on push to master #196

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Feb 13, 2024

This disables building the Docker image on push to master, which was first enabled in #186. This workflow was simply not triggered before, but currently fails #191.

Publishing such a Docker image is not needed for the system tests anymore.

@BenjaminRodenberg @IshaanDesai I am directly contributing to the master branch as a hotfix, since this only fixes (disables) the broken GitHub Actions workflow.

@MakisH
Copy link
Member Author

MakisH commented Feb 13, 2024

This of course only "fixes" the GitHub view. I can also fully revert all other changes to the Dockerfile etc and revert to the previous state (which would still break if anyone tried to build for master, as before we ever touched this workflow, but one would never see that).

@MakisH
Copy link
Member Author

MakisH commented Feb 13, 2024

Note also that, as I am not a maintainer of this repository, I have no idea what side-implications pushing to master has, so proceed with caution. I claim no responsibility for such side effects.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not foresee any issue right now. Pushing a hotfix directly to master should not be a problem.

@BenjaminRodenberg
Copy link
Member

I think the main question here is what we actually want. I already discussed this to some degree with @fsimonis.

  1. If we want to release docker images with the python bindings - this also implies docker images for downstream projects like the fenics adapter - I don't think this is a good solution.
  2. If we only need docker images for testing, then we can probably skip the workflow for master and only regularly build a new version of precice/python-bindings:develop

My personal opinion: I can currently live without having an official docker release of the python bindings and the fenics adapter. Having the develop images is fine. With the releases on PyPI and conda I think our users also have good means to get the packages.

@IshaanDesai
Copy link
Member

My personal opinion: I can currently live without having an official docker release of the python bindings and the fenics adapter. Having the develop images is fine. With the releases on PyPI and conda I think our users also have good means to get the packages.

Remove some unnecessary code.
@BenjaminRodenberg
Copy link
Member

@MakisH I removed some code that should now have become unnecessary. Can you do a final check and then merge?

BenjaminRodenberg added a commit to precice/fenics-adapter that referenced this pull request Feb 16, 2024
See precice/python-bindings#196. We decided to not release a docker container for the python bindings and the fenics adapter, because this is unnecessary.
@MakisH
Copy link
Member Author

MakisH commented Feb 19, 2024

Looks good to me. You merge. :-)

@BenjaminRodenberg BenjaminRodenberg merged commit 8f943a1 into master Feb 19, 2024
18 checks passed
@BenjaminRodenberg BenjaminRodenberg deleted the disable-docker-build-master branch July 10, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants