Require setuptools>=61 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shown when building with spack).
fsimonis
approved these changes
Jul 9, 2024
I've put this into #208 |
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 27, 2024
* Require setuptools>=61. Will ensure use of pyproject.toml. * Simplify setup.py w.r.t noisy warning (always shown when building with spack).
BenjaminRodenberg
added a commit
that referenced
this pull request
Aug 27, 2024
* Require setuptools>=61. Will ensure use of pyproject.toml. * Simplify setup.py w.r.t noisy warning (always shown when building with spack).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring setuptools>=61 allows us to remove a noisy warning that always shows up when building with spack. It also allows us to simplify the
setup.py. Setuptools>=61 guarantees that pyproject.toml is used.