Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy with CI pipeline #213

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy with CI pipeline #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
882aff7
Restrict to numpy<2
BenjaminRodenberg Aug 27, 2024
3fafab1
Add changelog entry.
BenjaminRodenberg Aug 27, 2024
73ebff4
Also restrict numpy in pyproject toml.
BenjaminRodenberg Aug 27, 2024
de66ced
Restrict to setuptools < 72.
BenjaminRodenberg Aug 27, 2024
8953afc
Fix syntax.
BenjaminRodenberg Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.

## latest

* Restrict to numpy < 2 for better compatibility with CI pipeline. https://github.com/precice/python-bindings/pull/213
* Require setuptools < 72 since support for the test command was removed in Setuptools 72. https://github.com/precice/python-bindings/pull/213
* Require setuptools >= 61 to guarantee that pyproject.toml is used https://github.com/precice/python-bindings/pull/207
* Fix CI pipeline for spack https://github.com/precice/python-bindings/pull/206

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
# PEP 518 - minimum build system requirements
requires = ["setuptools>=61", "wheel", "Cython>=0.29", "packaging", "pip>=19.0.0", "numpy", "mpi4py", "pkgconfig"]
requires = ["setuptools>=61,<72", "wheel", "Cython>=0.29", "packaging", "pip>=19.0.0", "numpy<2", "mpi4py", "pkgconfig"]
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def initialize_options(self):
author_email='info@precice.org',
license='LGPL-3.0',
python_requires='>=3',
install_requires=['numpy', 'mpi4py', 'Cython'],
install_requires=['numpy<2', 'mpi4py', 'Cython'],
# mpi4py is only needed, if preCICE was compiled with MPI
# see https://github.com/precice/python-bindings/issues/8
packages=['precice'],
Expand Down
4 changes: 2 additions & 2 deletions spack/repo/packages/py-pyprecice/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ class PyPyprecice(PythonPackage):
depends_on("precice@" + ver, when="@" + ver)

depends_on("python@3:", type=("build", "link", "run"))
depends_on("py-setuptools@61:", type="build")
depends_on("py-numpy", type=("build", "link", "run"))
depends_on("py-setuptools@61:71", type="build")
depends_on("py-numpy@:1", type=("build", "link", "run"))
depends_on("py-mpi4py", type=("build", "run"))
depends_on("py-cython@0.29:", type="build")
depends_on("py-packaging", type="build")
Expand Down
Loading