-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHT tutorials for OpenFOAM and CalculiX #104
Conversation
I have set up a case for flow over hot plate, but in this case as well I am getting a same error as mention here.
Next, I will try and reinstall the CalculiX adapter because I think at least the tried heat exchanger should have worked. |
The only thing to edit in the CalculiX part now is the material properties (to be consistent with the benchmark case).
Hopefully, this is of help. |
I tried setting up the case as well and got segmentation faults using |
Is this meant to be for the flow over a plate CHT problem? |
@KyleDavisSA Yes. There is also one case which is modified FSI flap case.
No, I did not face this issue. Seems to be something else than what I am getting. |
I got the same error. The |
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/precice-mesh-id-1-error-openfoam-calculix-cht/313/11 |
@MakisH I have cleaned up the cases to the best of my knowledge. I have kept the 😄 |
Thank you for cleaning up, @Alphaoo1! We are now down to 226 changed files. I see changes across multiple tutorials and I am confused on what is exactly the purpose of this PR. Is it to add the flow-over-plate scenario we have with OpenFOAM, but with OpenFOAM and CalculiX? If yes, could you please remove any changes not related to this tutorial? Is the solver supposed to be |
This PR is for flow over plate with OpenFOAM and CalculiX.
The solver is |
The additional files were there because your Edit: how I did it: # Also add the preCICE repository as a remote so we can pull from it
git remote add precice git@github.com:precice/tutorials.git
# Change to your develop and pull from the precice:develop
git checkout develop
git pull precice develop
# Change to your branch and merge from develop, then push
git checkout CHT_OF-CCX
git merge develop
git push origin CHT_OF-CCX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments mostly for consistency with other tutorials, having another look at which CalculiX files we can remove (try moving them and running the case), and a few more important suggestions for the run scripts.
Keep up the hard work, we are getting there! 👍 👍
CHT/flow-over-plate/buoyantPimpleFoam-CalculiX/precice-config.xml
Outdated
Show resolved
Hide resolved
<use-data name="Heat-Flux"/> | ||
</mesh> | ||
|
||
<mesh name="Calculix_Mesh"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistency in the name style: OpenFOAM-Mesh
vs Calculix_Mesh
.
I suggest OpenFOAM-Mesh
and CalculiX-Mesh
.
CHT/flow-over-plate/buoyantPimpleFoam-CalculiX/precice-config.xml
Outdated
Show resolved
Hide resolved
CHT/flow-over-plate/buoyantPimpleFoam-CalculiX/precice-config.xml
Outdated
Show resolved
Hide resolved
@MakisH In a nutshell I made the following changes:
As for the Solid participant and it's files, I have added things one can do to generate those files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for applying most of the suggestions already! Here are a few more ones (in most of them you can just apply the diff suggestions).
As for the Solid participant and it's files, I have added things one can do to generate those files.
This may be used as a backup options if some file gets deleted.
But as for a new comer, or someone who is new to CalculiX I think these might be complicated.
I agree that we should not assume previous CalculiX knowledge and I like that you added the steps in the README! 😄
I have not yet tried to run the tutorial, I will try after we resolve most of these points.
# You can use CalculiX CGX to setup the structural simulation from sratch. | ||
# This will re-generate the all.msh, fix1_beam.nam, interface_beam.nam files. | ||
# | ||
# # Prepare in silent mode | ||
# echo "Preparing the ${Participant2} participant..." | ||
# cd ${Participant2} | ||
# echo " Executing cgx (provided by CalculiX, make sure this exists)..." | ||
# cgx -bg pre_flap.fbd > prepare_flap.log 2>&1 | ||
# cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check: does this actually work in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the README it looks like this is the respective step:
cgx -c Mesh_Coarse_OUT.inp
* **OpenFOAM and OpenFOAM adapter:** To make sure that everything is working properly, you should run the [similar OpenFOAM-OpenFOAM tutorial case](https://github.com/precice/openfoam-adapter/wiki/Tutorial-for-CHT:-Flow-over-a-heated-plate). | ||
|
||
### Generating CacluliX files | ||
After installing the CalculiX adapter, CalculiX on it's own should also be available in the system. If not, an easy to use precomplied [tool](http://www.calculixforwin.com/) may be used to produced the required files (the commands remain same, use the pre-processing option). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not correct. It is not necessary to compile a "normal" CalculiX to compile ccx_preCICE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think may be my wording was not clear, I was trying to say the same, we do not need to install "normal" CalculiX.
Isn't it installed directly when we installed the adapter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If one runs make
only in the adapter's repository, no. The user only needs to have the CalculiX code somewhere. But I agree that a CalculiX user would also install the normal ccx
.
<data:scalar name="Sink-Temperature-0"/> | ||
<data:scalar name="Heat-Flux"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you use Heat-Flux-0
everywhere (also in the OpenFOAM and CalculiX adapters), then it should work. The OpenFOAM adapter supports this.
@@ -0,0 +1,19 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs to be deleted.
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@@ -1,18 +1,10 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, keep it! It makes it explicit that this is a Bash script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to delete the file ./Fluid/runFluid
, since we also have the ./runFluid
@@ -1,5 +1,3 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: do not remove this line.
nactdog | ||
|
||
nacteq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file for?
@Alphaoo1 we restructured the tutorials as a larger project https://github.com/orgs/precice/projects/5 This contribution is still quite important, but I think it woul dbe much easier to close this now and submit a new PR again, with the new structure in mind. Since now most files are already there (OpenFOAM case, README.md, scripts, Thank you once more already for the work so far, I am only closing this to keep a better overview of what is actively open. |
@MakisH Yes, I will surely have a look at the contributions guidelines and see how can I contribute. |
I have added the OpenFOAM+CalculiX CHT case, which have some issues from CalculiX side.
I took the general setup of the flap case from the FSI.
I have adapted the CHT part similar to the heat-exchanger case.
I am currently working on making a flow over the heat plate case similar to OF+Nutils. I will push as soon as I am done, working towards Issue #103 .