Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing lazy loading with infinite scroll #66

Closed
benmak11 opened this issue Oct 27, 2016 · 10 comments
Closed

Allowing lazy loading with infinite scroll #66

benmak11 opened this issue Oct 27, 2016 · 10 comments

Comments

@benmak11
Copy link

Hi,

This is not really an issue but more of a feature request. Is it possible to have infinite scroll with a restricted pageSize view of 25 items? I know that out of the box, px-data-table does support lazy loading via paginating the data set (and restricting the displayed set of data to the page size that you stipulate). px-data-table does not support infinite scroll, which is what I am trying to achieve. More details on this is here.

@mdwragg
Copy link
Contributor

mdwragg commented Oct 27, 2016

Hi,

Thanks for your feature request! We don't have plans to build this feature right now. Can you help us build it? We love pull requests!

Thanks!

@benmak11
Copy link
Author

Okay @mdwragg! I will do that. Once the pull request is submitted and accepted, I will close this issue.

Thanks

@mdwragg
Copy link
Contributor

mdwragg commented Oct 27, 2016

Awesome! @benmak11 I can't wait to see it :) 💯

@benmak11
Copy link
Author

@mdwragg could I get access to this repo? I can't create a branch cause I run into this in the command line:
screen shot 2016-10-27 at 11 54 49 am

@mdwragg
Copy link
Contributor

mdwragg commented Oct 27, 2016

Hi Ben, you will make your changes in a fork of this repo. Fork the repo to your personal GitHub account, make your changes then create a PR pointing to your changes (there are tons of guides on the internet on how to do this). Let us know if you get stuck!

@benmak11 benmak11 mentioned this issue Nov 14, 2016
@jouni
Copy link

jouni commented Nov 17, 2016

Hi!

I noticed this feature request and followed the discussion at http://forum.predix.io/answers/14038/view.html, where Baynham Makusha linked to vaadin-grid as an alternative to use.

I started to wonder if you would be interested in bringing vaadin-grid into Predix UI? We’re currently actively working on vaadin-grid 2.0 (check the latest preview demos), and we would be very interested in hearing why you would not consider it and would rather write your own data table element (missing features, unwanted features, political reasons or something else).

As a sidenote, the Predix UI library and design system are a real inspiration for us at Vaadin, so keep up the good work!

@randyaskin
Copy link
Contributor

randyaskin commented Jun 29, 2017

Will be (sort of) introduced with #126 - not exactly the same as infinite scroll I guess.

@benmak11
Copy link
Author

benmak11 commented Jul 7, 2017

@randyaskin has this PR been merged into master? I would like to take a look at the final solution

@randyaskin
Copy link
Contributor

Nope, if you click on the link you'll see the status, latest commits, and conversation with Evan though. Maybe you can help him with his I.E. woes.

@mdwragg
Copy link
Contributor

mdwragg commented Nov 28, 2017

Lazy loading now available. Infinite scroll will be available in the new data table (coming soon). Closing this issue.

@mdwragg mdwragg closed this as completed Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants