Remote Data Paradigm

[evandana]

Summary

Allows grid to accommodate server-centric data source

Example

• Given: 10,000 alarms in a system
• UI would request one page's worth of data, 10 records
• UI would be provided with meta data such as total number of records (10,000)
• UI can display one page while generating pagination UI for all 10,000

Technical Debt

• demo.html page been added, but could use review (separate effort from this PR)
  • Work on demo page done by @dcheepurupalli
  • Help is welcomed

Technical Notes

<px-data-table 
            data-remote="true"
            enable-column-resize="true"
            filterable$={{_filterable}} 
            first-item-index="{{_firstItemIndex}}"
            greedy-height-with-scroll="true"
            id="alarmGrid" 
            page-size="{{_pageSize}}" 
            show-column-chooser="true" 
            table-data="[[_alarms]]" 
            table-rows="true" 
            total-entries="{{_filteredCount.filtered}}"
            >
</px-data-table>

[mdwragg]

Yeah, I just checked it out and that appears to be a regression @evandana.

[mdwragg]

Sorry, should've made that clearer, the right border disappearance appears to be a regression only in this PR. In master this does not occur.

[mdwragg]

Hey @evandana - great fixes, thanks! Sadly I can't run the unit tests on IE and I got a failing test on Edge.

For IE, I think we've got too much running on one page, I suggest you pull the 'remote' fixtures and tests out to a separate suite and fixture (see the px-data-table-cell-fixture.html and associated test for inspiration.

Thanks!

[mdwragg]

Hi @evandana - I split the tests up (https://github.com/PredixDev/px-data-table/tree/remote-pr) and copied the changes out to a branch on this repo (so I could run the whole suite of tests against Sauce Labs in our CI environment).

Sadly the tests still fail in IE... We need them working in IE before we can accept the change. I'll leave that branch around for a while so you can see the pattern for splitting the tests up. Thanks!

[evandana]

Thanks! I split them up myself, but haven't pushed that change. I'll check your branch. Thanks for your help with it. I'm a little stuck on how to test with IE since I'm on a mac. What do you use for testing with IE?

…

On Wed, Jul 5, 2017 at 4:10 PM Martin Wragg ***@***.***> wrote: Hi @evandana <https://github.com/evandana> - I split the tests up ( https://github.com/PredixDev/px-data-table/tree/remote-pr) and copied the changes out to a branch on this repo (so I could run the whole suite of tests against Sauce Labs in our CI environment). Sadly the tests still fail in IE... We need them working in IE before we can accept the change. I'll leave that branch around for a while so you can see the pattern for splitting the tests up. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#126 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0WTBbamAFfacIE7CJDjgfUl2KIlzIEks5sK-3JgaJpZM4NPx60> .

[mdwragg]

Good point.... We either use the free VMs from https://modern.ie (https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/) or the 'manual test session' option on SauceLabs (there you can pick an IE VM that gives you 10 minutes of use).

To access a local running version of your tests (on your mac) do; wct -p from one terminal window, then in another terminal window using ngrok (link below), do ngrok http 2000 - You'll then get URL to your tests that you can access from anywhere (either a local VM or SauceLabs VM) by going to http://<ngrok url>/components/px-data-table/generated-index.html.

https://ngrok.com/

[mdwragg]

💯 🐐 👍 🥇

Thanks!