RTL changes for dropdown to properly space carat

predixdesignsystem · Feb 11, 2019 · 37f3de3 · 37f3de3
1 parent aecc4a2
commit 37f3de3
Show file tree

Hide file tree

Showing 7 changed files with 382 additions and 373 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,6 @@
+# v4.9.1
+- Fixed Dropdown icon spacing issue when the rendering direction is "rtl" Right-To-Left.
+
 # v4.9.0
 
 - Added `--px-icon-flex-grow` CSS variable for optionally allowing the dropdown to fill its container

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "px-dropdown",
-  "version": "4.9.0",
+  "version": "4.9.1",
   "main": [
     "px-dropdown.html"
   ],

diff --git a/css/px-dropdown-styles.html b/css/px-dropdown-styles.html
diff --git a/demo/simple_demo.html b/demo/simple_demo.html
@@ -28,7 +28,7 @@
 
 </head>
 
-<body>
+<body dir="rtl">
   <custom-style>
     <style include="px-theme-styles" is="custom-style"></style>
   </custom-style>
@@ -37,12 +37,15 @@
     body {
       height: 200vh;
     }
+    .rtl {
+      direction: rtl;
+    }
   </style>
   <px-overlay-container container-type="foo"></px-overlay-container>
   <px-overlay-container container-type="bar"></px-overlay-container>
   <px-overlay-container container-type="baz"></px-overlay-container>
 
-  <div style="width:250px">
+  <div style="width:250px" class="rtl">
     <p>Single Select</p>
     <px-dropdown
       id="foo"
@@ -99,7 +102,7 @@
     </px-dropdown>
     </br>
     <p>Single Select Read Only</p>
-    <px-dropdown 
+    <px-dropdown
       id="readOnly"
       display-value="Read Only Items"
       container-type="readOnly"