Add icon margin that works on both LTR & RTL, re-add removed styles (#…

…104)

* add margin right

So all icons will have margin left and margin right, so we dont need browser prefix fixes plus works for IE

* add margin left and right for item icon

* Combine into one PR so we dont have multiple PR's

HISTORY.md

@@ -1,3 +1,8 @@
+# v4.9.3
+
+- Use margin right and left to avoid browser specific prefix fix for rtl space issue.
+- Re-add the padding styles that was removed that caused regression.
+
 # v4.9.2
 
 - Resolved regression in iconic menu trigger size.

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "px-dropdown",
-  "version": "4.9.2",
+  "version": "4.9.3",
   "main": [
     "px-dropdown.html"
   ],

package.json

@@ -2,7 +2,7 @@
   "name": "px-dropdown",
   "author": "General Electric",
   "description": "A Predix UI Dropdown component",
-  "version": "4.9.2",
+  "version": "4.9.3",
   "extName": null,
   "scripts": {
     "clean": "gulp clean",

sass/px-dropdown.scss

@@ -62,13 +62,7 @@ $inuit-enable-btn--primary: true;
   --iron-icon-width: 1.06667rem;
   --iron-icon-height: 1.06667rem;
   margin-left: $inuit-base-spacing-unit--tiny;
-  /*
-    These margins are for pages that are rendered from "Right-To-Left" or "Left-To-Right"
-    If the writing direction is left-to-right, this value overrides margin-left.
-    If the writing direction is right-to-left, this value overrides margin-right.
-  */
-  -webkit-margin-start: $inuit-base-spacing-unit--tiny;
-  -moz-margin-start: $inuit-base-spacing-unit--tiny;
+  margin-right: $inuit-base-spacing-unit--tiny;
 }
 .dropdown {
   font-size: var(--px-dropdown-content-font-size, inherit);
@@ -223,6 +217,8 @@ $inuit-enable-btn--primary: true;
 .item-icon {
   --iron-icon-width: var(--px-dropdown-item-icon-size, calculateRem(16px));
   --iron-icon-height: var(--px-dropdown-item-icon-size, calculateRem(16px));
+  margin-right: $inuit-base-spacing-unit--tiny;
+  margin-left: $inuit-base-spacing-unit--tiny;
 }
 .checkbox {
   margin-right: $inuit-base-spacing-unit--tiny;
@@ -309,3 +305,9 @@ $inuit-enable-btn--primary: true;
   border-width: 6px;
   margin-left: -6px;
 }
+
+$inuit-enable-paddings--small: true;
+$inuit-enable-paddings--tiny: true;
+$inuit-enable-paddings--none: true;
+$inuit-enable-margins--small: true;
+@import "px-spacing-design/_trumps.spacing.scss";