Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed chrome non-unique id error #88

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

itzzshirlayyy
Copy link
Collaborator

@itzzshirlayyy itzzshirlayyy commented Sep 5, 2018

  • Removed id #searchbox from px-dropdown and used the class variable .search__box.
  • This ensures no duplicate 'non-unique id' error that chrome console checks for (pic below)

screen shot 2018-09-04 at 6 09 40 pm

^ this error no longer displays on the console after this fix:
screen shot 2018-09-04 at 6 45 47 pm

@cla-bot cla-bot bot added the cla-signed label Sep 5, 2018
@evanjd evanjd self-requested a review September 5, 2018 00:52
@sks sks merged commit c0d3a90 into predixdesignsystem:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants