Make display value count a variable #69 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arongraham-ge
requested review from
bentwonk,
evanjd,
joshsylvester and
MichaelZaporozhets
evanjd
reviewed
Jan 4, 2019
joshsylvester
approved these changes
Jan 4, 2019
| @@ -618,10 +621,12 @@ | |||
| * the label displayed inside the dropdown. | |||
| */ | |||
| _handleDeselection: function(evt) { | |||
| if(this.multi && this.$.selector.selectedItems.length === 1 && !this.hideSelected) { | |||
| this.displayValueSelected = this.$.selector.selectedItems[0].innerText.trim(); | |||
| if(this.multi && this.$.selector.selectedItems.length > 0 && this.$.selector.selectedItems.length <= this.displayValueCount && !this.hideSelected) { | |||
There was a problem hiding this comment.
does px have a line length standard? this line & line 590 could possibly be broken up into something shorter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new property to make the number of selected values used in the trigger label variable.
The new property is
display-value-countand its default value is 1, which is the current default behaviour.display-value-countis greater then 1 that number of values displayed in the px-dropdown trigger button.multiproperty of px-dropdown is also set.display-value-countwill display as "N Selected", like the current behaviourNew property allows the button label to look like this:
