Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a file guard to indicate if an environment is being installed #1593

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

baszalmstra
Copy link
Contributor

Fixes #1577

This adds a .guard file to the prefix which is locked using advisory guards and records the state of the environment. This allows detection if the installation of an environment was aborted and also ensures that if two processes run concurrently they will not interfere.

@baszalmstra baszalmstra requested a review from tdejager July 9, 2024 10:49
Copy link
Contributor

@tdejager tdejager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move prefix_guard to utils?

@wolfv
Copy link
Member

wolfv commented Jul 9, 2024

Should we do this in rattler?

@baszalmstra
Copy link
Contributor Author

Should we do this in rattler?

Yeah but Im not entirely sure about the API yet, so experimenting here for now. :)

@wolfv
Copy link
Member

wolfv commented Jul 9, 2024

I think this would be great in a high level transaction api

@wolfv
Copy link
Member

wolfv commented Jul 9, 2024

But fine to have it here for now, of course

@baszalmstra baszalmstra merged commit f6c67d4 into prefix-dev:main Jul 9, 2024
24 checks passed
@baszalmstra baszalmstra deleted the fix/exec_env_reuse branch July 9, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exec broken after aborted environment creation
3 participants