-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow for init to pixi.toml when pyproject.toml is available. #1640
fix: allow for init to pixi.toml when pyproject.toml is available. #1640
Conversation
Mm could we rename the flag to something like --force-pixi-toml or something like that? I think --pixi is a bit ambiguous. |
src/cli/init.rs
Outdated
.interact() | ||
} else { | ||
Ok(args.pyproject) | ||
}.into_diagnostic()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diagnostic only ever applies to dialoguer so I would just move it in the if branch.
I think because the other CLI flag is |
I understand that, but |
Indeed, maybe we could have something like edit or add |
Any of those are better than |
I guess, having autocompletion would be nice here. So |
Dont you also get autocompletion for the style option? |
You would need to write a dynamic complete script for each shell and patch the completions scripts. Edit: this does work for enums indeed. |
Not if style is just an enum right? At least thats the case for nushell conpletions I think. |
@baszalmstra Updated this. Now it's |
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Adds a dialog for
pyproject.toml
use, and an option to overwrite the dialog with--format pixi
Fixes #1615 #1207