Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: delay channel config url evaluation #1662

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

baszalmstra
Copy link
Contributor

Uses the NamedChannelOrUrl type from rattler to delay channel url evaluation.

@ruben-arts
Copy link
Contributor

fixed the tests in baszalmstra#3

@wolfv
Copy link
Member

wolfv commented Jul 24, 2024

This is great. Does this also mean we get relative file paths channels as relative to the pixi.toml now? :)

@baszalmstra
Copy link
Contributor Author

Thanks @ruben-arts !

Im not quite done though. There are more uses that I wanna take care of.

@ruben-arts ruben-arts marked this pull request as draft July 24, 2024 11:31
@ruben-arts
Copy link
Contributor

Great! Will put it on draft for the overview.

@wolfv
Copy link
Member

wolfv commented Jul 24, 2024

For reference - the issue about relative channel paths: #1159

@baszalmstra baszalmstra marked this pull request as ready for review July 25, 2024 08:52
@baszalmstra
Copy link
Contributor Author

baszalmstra commented Jul 25, 2024

For reference - the issue about relative channel paths: #1159

I added support for setting the proper root dir but Im not entirely sure if it works because parsing the NamelessMatchSpec also requires the root config.

But Im pretty sure that it does fix the issue referenced in the issue.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@baszalmstra baszalmstra merged commit 550f9c0 into prefix-dev:main Jul 25, 2024
24 checks passed
@baszalmstra baszalmstra deleted the fix/delay_channel_config branch July 25, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants