-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: delay channel config url evaluation #1662
refactor: delay channel config url evaluation #1662
Conversation
fixed the tests in baszalmstra#3 |
This is great. Does this also mean we get relative file paths channels as relative to the pixi.toml now? :) |
Thanks @ruben-arts ! Im not quite done though. There are more uses that I wanna take care of. |
Great! Will put it on draft for the overview. |
For reference - the issue about relative channel paths: #1159 |
I added support for setting the proper root dir but Im not entirely sure if it works because parsing the But Im pretty sure that it does fix the issue referenced in the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Uses the
NamedChannelOrUrl
type fromrattler
to delay channel url evaluation.