fix: pixi add with more than just package name and version
#1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
approved these changes
Jul 30, 2024
ruben-arts
changed the title
pixi add --pypi package[extra]
|
@baszalmstra I wasn't happy, and found out |
ruben-arts
commented
Jul 31, 2024
tests/add_tests.rs
Outdated
| let pixi = PixiControl::new().unwrap(); | ||
|
|
||
| pixi.init() | ||
| .no_fast_prefix_overwrite(true) |
There was a problem hiding this comment.
Can't use url's in matchspecs yet, fix in: conda/rattler#792
tests/add_tests.rs
Outdated
| .await | ||
| .unwrap(); | ||
|
|
||
| pixi.add("conda-forge::py_rattler").without_lockfile_update().await.unwrap(); |
There was a problem hiding this comment.
Currently still a slow test as there is a bug in this --no-lockfile-update so it is actually solving. This is fixed in: #1683
There was a problem hiding this comment.
Otherwise I would have used the mock PackageDatabase 😉
ruben-arts
changed the title
pixi add --pypi package[extra]pixi add with more than just package name and version
tdejager
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697
We broke
pixi add --pypi pytest[dev]as it didn't add the [dev] anymore. Now that is fixed.