-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make conda-pypi-map relative to manifest #3079
base: main
Are you sure you want to change the base?
Conversation
985f6e6
to
3c89342
Compare
I see that I broke some of the tests, I'll update this later today |
This makes the conda-pypi-map file path relative to the pixi manifest, which makes the behavior independent of which directory you execute pixi from. This resolves issue prefix-dev#2615
17a6fbd
to
2671498
Compare
I am a bit lost on what the error is here, and my limited rust and Pixi knowledge is a blocker. Could you point me in the right direction @Hofer-Julian ? |
Thanks for your contribution @rHermes. I don't see though how your changes to the tests actually test that relative mappings now work correctly :) |
Ah no they don't, I was trying to preserve the original setup of the tests and maybe adding a specific test to check for the relative nature. What do you think about this? |
Yes, please do that :) |
This makes the conda-pypi-map file path relative to the pixi manifest, which makes the behavior independent of which directory you execute pixi from.
This resolves issue #2615