Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make conda-pypi-map relative to manifest #3079

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rHermes
Copy link

@rHermes rHermes commented Feb 7, 2025

This makes the conda-pypi-map file path relative to the pixi manifest, which makes the behavior independent of which directory you execute pixi from.

This resolves issue #2615

@rHermes rHermes force-pushed the make-pypi-map-relative branch from 985f6e6 to 3c89342 Compare February 7, 2025 09:45
@Hofer-Julian Hofer-Julian changed the title Make conda-pypi-map relative to manifest fix: make conda-pypi-map relative to manifest Feb 7, 2025
@rHermes
Copy link
Author

rHermes commented Feb 7, 2025

I see that I broke some of the tests, I'll update this later today

This makes the conda-pypi-map file path relative to the pixi manifest,
which makes the behavior independent of which directory you execute pixi
from.

This resolves issue prefix-dev#2615
@rHermes rHermes force-pushed the make-pypi-map-relative branch from 17a6fbd to 2671498 Compare February 7, 2025 13:54
@rHermes
Copy link
Author

rHermes commented Feb 7, 2025

I am a bit lost on what the error is here, and my limited rust and Pixi knowledge is a blocker. Could you point me in the right direction @Hofer-Julian ?

@Hofer-Julian
Copy link
Contributor

I am a bit lost on what the error is here, and my limited rust and Pixi knowledge is a blocker. Could you point me in the right direction @Hofer-Julian ?

Thanks for your contribution @rHermes.
That specific job is flaky unfortunately, nothing to do with your changes.

I don't see though how your changes to the tests actually test that relative mappings now work correctly :)

@rHermes
Copy link
Author

rHermes commented Feb 10, 2025

Ah no they don't, I was trying to preserve the original setup of the tests and maybe adding a specific test to check for the relative nature. What do you think about this?

@Hofer-Julian
Copy link
Contributor

Ah no they don't, I was trying to preserve the original setup of the tests and maybe adding a specific test to check for the relative nature. What do you think about this?

Yes, please do that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants