fix: skip unneeded url parse and only add git+ when needed #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichmor
reviewed
Feb 14, 2025
| @@ -239,7 +239,7 @@ async fn add_functionality_os() { | |||
|
|
|||
| /// Test the `pixi add --pypi` functionality | |||
| #[tokio::test(flavor = "multi_thread", worker_threads = 1)] | |||
| #[cfg_attr(not(feature = "slow_integration_tests"), ignore)] | |||
| // #[cfg_attr(not(feature = "slow_integration_tests"), ignore)] | |||
There was a problem hiding this comment.
oowps nope, did that for testing locally
tdejager
reviewed
Feb 15, 2025
| let url_str = git.to_string(); | ||
| let stripped = url_str.strip_prefix("git+").unwrap_or(&url_str); | ||
| // Reparse the url with the new scheme, should be safe but could fail so fall back to the original. | ||
| Url::parse(stripped).unwrap_or(git.clone()) |
There was a problem hiding this comment.
Should this not be an actual error? When would it be okay if this fails?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second time parsing the git URL would remove the
git@fromssh://git@github..which is not right in this case.TODO: