Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add user agent to pixi http client #892

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

baszalmstra
Copy link
Contributor

This PR adds a user agent to the http Client. Apparently this is needed for some mirrors.

Fixes #753

@wolfv
Copy link
Member

wolfv commented Mar 1, 2024

Nice. We should do the same in rattler-build then.

@wolfv
Copy link
Member

wolfv commented Mar 1, 2024

Or should we add a default user agent in rattler as well?

@baszalmstra
Copy link
Contributor Author

You have to set the user-agent on the client itself. This is passed into the rattler functions. You also cant request the user agent from the client so there is also no way to know in rattler whether one was already provided. So yeah I guess we also need to modify rattler-build to set a user-agent.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine!

@ruben-arts ruben-arts merged commit 769d77b into prefix-dev:main Mar 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP status client error (403 Forbidden) for public mirror channel
3 participants