feat: move favored,locked package and env variables into ResolveOptions #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
reviewed
Feb 16, 2024
| @@ -434,7 +431,7 @@ mod tests { | |||
| let (wheel_builder, _temp) = setup(ResolveOptions::default()).await; | |||
|
|
|||
| // Build the wheel | |||
| wheel_builder.build_wheel(&sdist).await.unwrap(); | |||
| wheel_builder.clone().build_wheel(&sdist).await.unwrap(); | |||
There was a problem hiding this comment.
Why do we need the clone here?
There was a problem hiding this comment.
because later we do this:
// Build the wheel
wheel_builder.build_wheel(&sdist).await.unwrap();
// See if we can retrieve it from the cache
wheel_builder
.package_db
.local_wheel_cache()
.wheel_for_key(&key)
.unwrap()
.unwrap();
and wheel builder is moved because of build_wheel
There was a problem hiding this comment.
Wait.. we don't want that at all, then we should accept a self: &Arc<self> in the WheelBuilder we definitely do not want to move for each method call
There was a problem hiding this comment.
That would result in too many clones.
There was a problem hiding this comment.
agree - changed to passing references
tdejager
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.