mailchimp emails #114
Merged
mailchimp emails #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me looks good, but I would like @Janaka-Steph opinion on this. |
|
@casperdcl can you paste here the Form layout? Did you manage to replicate it the same as the form we were having in Mailchimp? |
Janaka-Steph
approved these changes
Nov 25, 2023
|
this is what the modal looks like; basically same as before...
|
|
LGTM. Let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchto circumvent mailchimp's CORSiframe)the above hacks are necessary since (afaik) mailchimp doesn't provides a proper JSON API with configurable CORS, and we don't want to hardcode API keys here. Less hacky solutions are welcome /CC @Janaka-Steph :)