Fixed bug with linkgroups only working on Premake projects

premake · Feb 8, 2020 · f8a88c3 · f8a88c3
1 parent a640f86
commit f8a88c3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/src/tools/gcc.lua b/src/tools/gcc.lua
@@ -467,11 +467,6 @@
 			end
 		end
 
-		if not nogroups and #result > 1 and (cfg.linkgroups == p.ON) then
-			table.insert(result, 1, "-Wl,--start-group")
-			table.insert(result, "-Wl,--end-group")
-		end
-
 		-- The "-l" flag is fine for system libraries
 		local links = config.getlinks(cfg, "system", "fullpath")
 		local static_syslibs = {"-Wl,-Bstatic"}
@@ -511,6 +506,11 @@
 		end
 		move(shared_syslibs, result)
 
+		if not nogroups and #result > 1 and (cfg.linkgroups == p.ON) then
+			table.insert(result, 1, "-Wl,--start-group")
+			table.insert(result, "-Wl,--end-group")
+		end
+
 		return result
 	end
 

diff --git a/tests/tools/test_gcc.lua b/tests/tools/test_gcc.lua
@@ -504,6 +504,24 @@
 	end
 
 
+--
+-- Test that sibling and external links are grouped when required
+--
+
+	function suite.linkgroups_onSiblingAndExternalLibrary()
+		links { "MyProject2", "ExternalProj" }
+		linkgroups "On"
+
+		test.createproject(wks)
+		system "Linux"
+		kind "StaticLib"
+		targetdir "lib"
+
+		prepare()
+		test.isequal({ "-Wl,--start-group", "lib/libMyProject2.a", "-lExternalProj", "-Wl,--end-group" }, gcc.getlinks(cfg))
+	end
+
+
 --
 -- When linking object files, leave off the "-l".
 --