Fix gmake dependencies #1005
Merged
Fix gmake dependencies #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure you discuss this change with @bwhittle (at World of Warcraft). Other then the test failures, the change looks fine to me. |
|
This has been tested now on a large project. |
|
If someone wants to bless, this makes parallel builds work with make. |
starkos
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
@TurkeyMan, do you not have the ability to approve? Thought you did…I'll approve now.
starkos
requested changes
Mar 22, 2018
|
Sure, I can approve til the cows come home (I created this github account!) :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #981
Note, this patch doesn't implement any logic to prevent execution of the prebuild step if the project is not dirty... it will ALWAYS run prebuild, just like gmake output always has, but the deps should now be structured that parallel builds work.