Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include library directories in Codelite projects #1023

Merged
merged 7 commits into from
Apr 22, 2018

Conversation

Gaztin
Copy link
Contributor

@Gaztin Gaztin commented Mar 26, 2018

No description provided.

@samsinsane
Copy link
Member

@tvandijck you removed this here, are you able to recall why?

@tvandijck
Copy link
Contributor

I tried to get Starcraft 2 working in CodeLite on Linux for Deepmind, so the changes I made are based on that attempt.
@TurkeyMan would have to confirm if Blizzard is still using this and object to these changes or not.

@starkos starkos assigned starkos and TurkeyMan and unassigned starkos Apr 6, 2018
@starkos starkos requested a review from TurkeyMan April 16, 2018 18:39
@starkos
Copy link
Member

starkos commented Apr 16, 2018

Assigned @TurkeyMan as a reviewer.

@TurkeyMan
Copy link
Contributor

Blizzard are still using it (not actively) as far as I can tell, but assuming this change is right (it looks right!), then I can't object to it!
There must be some reason why it was removed in the first place though?
Can the author of this PR give confidence that this is correct? If someone who's actively using it is satisfied, then I'm satisfied :)

@Gaztin
Copy link
Contributor Author

Gaztin commented Apr 20, 2018

Yeah it's correct in my use case, which is just a typical C++ workspace with one application project and a couple of static library projects that the application uses.

It wasn't finding the library files, so I overrode the linker function and added the same changes as in this PR. Afterwards, it worked fine!

Edit: Here's the code

@samsinsane samsinsane merged commit 36a77d2 into premake:master Apr 22, 2018
@Gaztin Gaztin deleted the codelite-libdirs branch April 22, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants