Replace last global state block in api.reset #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to premake#1021: I removed the state blocks added by the tests, but neglected to put back a new, empty global state block for the next run.
samsinsane
approved these changes
Apr 3, 2018
There was a problem hiding this comment.
LGTM, I have no idea why that one macOS build won't work. It's looking for your branch in this repo instead of your repo, but the Linux build did the same thing and worked. None of the other open PRs has the check continuous-integration/travis-ci/push they only have continuous-integration/travis-ci/pr. You might need to push the branch again or something?
I'm happy to merge as-is given that your "pr" check works and the changes are minimal. I'll leave it up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1021: I removed the state blocks added by the tests, but neglected to put back a new, empty global state block for the next run.