HLSL Shader compilation in Visual Studio #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
approved these changes
Apr 8, 2018
| m.categories.FxCompile = { | ||
| name = "FxCompile", | ||
| extensions = { ".hlsl" }, | ||
| priority = 3, |
There was a problem hiding this comment.
Does this need to be priority 3?
There was a problem hiding this comment.
Not really.
I implemented it some time ago so I don't remember it that clearly but it might be that vs add this block just after the ClCompile block so I wanted to reproduce this.
I can update this to keep the previous priority order if you'd prefer.
There was a problem hiding this comment.
Fair enough, I see no reason to hold the PR up over this. What you have is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio can compile HLSL shaders with the FxCompile block.
As far as I know, this is available at least from vs2012. I did not test for earlier versions.
There is one thing bothering me with this implementation, I had to create shaderdefines and shaderoptions even though the resulting tag is the same as ClCompile.
This is to avoid doing something like
as it would be treated as a per-file config instead of a block one.
If you have any idea to improve this, I'm up to implement it.