Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debuggerflavor API #1045

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Conversation

tdesveauxPKFX
Copy link
Contributor

No description provided.

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we'll still need to add the elements to emit remote debugger values, and whatever the web ones do. A project at work uses both the remote and local debuggers, it'll be nice to see the remote debugger supported in core better. Great stuff!

"WindowsLocalDebugger",
"WindowsRemoteDebugger",
"WebBrowserDebugger",
"WebServiceDebugger"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could simply be:

"Local",
"Remote",
"WebBrowser",
"WebService",

I would recommend not using the VS element values for the API values. VS changes the values sometimes and you'll end up needing a lookup table anyway, others adding support for VS extensions might need to use different values too.

debuggerflavor "WindowsRemoteDebugger"
prepare()
test.capture [[
<DebuggerFlavor>WindowsRemoteDebugger</DebuggerFlavor>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this just set the "default" debugger?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, when you press F5 you use the Local debugger, does this element change the default to the Remote debugger? To use the remote debugger at work we ended up adding this to our premake5.lua:

premake.override(premake.vstudio.vc2010, "debugSettings", function(oldfn, cfg)
    oldfn(cfg)
    premake.w('<RemoteDebuggerCommand>...</RemoteDebuggerCommand>')
    premake.w('<RemoteDebuggerWorkingDirectory>...</RemoteDebuggerWorkingDirectory>')
    premake.w('<RemoteDebuggerServerName>...</RemoteDebuggerServerName>')
    premake.w('<RemoteDebuggerConnection>RemoteWithoutAuthentication</RemoteDebuggerConnection>')
end)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a naive implementation for this one.
I never use any of these values actually. I need this API to add other values that can't be added here due to NDAs and such.
If you feel that this should be implemented all the way, I can take care of it,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start for fleshing out the debugger options. If I get a chance I might try to add the remote values. 👍

@samsinsane samsinsane merged commit dc641e5 into premake:master Apr 11, 2018
@tdesveauxPKFX tdesveauxPKFX deleted the debuggerflavor branch April 12, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants